[LOGBACK-1583] Search for @NoAutoStart annotations in ancestor hierarchy, implemented interfaces and meta-annotations #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d interfaces and meta-annotations Adresses issue LOGBACK-1583 Signed-off-by: Bertrand Renuart <brenuart@gmail.com>
brenuart
force-pushed
the
#1583-NoAutoStart
branch
from
6d5ef1c
to
f66c0cf
Compare
brenuart
changed the title
ceki
approved these changes
Apr 11, 2024
| return (A) ann; | ||
| } | ||
| } | ||
| for (Annotation ann : anns) { |
There was a problem hiding this comment.
While I can see the purpose of looking at super classes. Is there a use for looking at other annotations to search for a given annotation?
|
Thank you for this PR. After merging, I removed support for annotated annotations in commit f32ed30. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses issue LOGBACK-1583